Resolve ML cluster failures#957
Merged
ayushdg merged 6 commits intodask-contrib:mainfrom Dec 6, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #957 +/- ##
==========================================
+ Coverage 76.62% 76.76% +0.14%
==========================================
Files 73 73
Lines 4115 4119 +4
Branches 751 751
==========================================
+ Hits 3153 3162 +9
+ Misses 792 783 -9
- Partials 170 174 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
|
Interesting, I wasn't familiar with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like something changed in upstream Dask such that we're now seeing issues when trying to use the local ML wrapper functions introduced in #832 and #855 in an independent cluster; this PR wraps these relevant function usages with
make_pickable_without_dask_sqlas is done with other functions passed directly off to Dask, and adds theskip_if_external_schedulermarker to relevant tests that would otherwise need scikit-learn.cc @sarahyurick